Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sink): merge small chunks for sink executor #17825

Merged
merged 1 commit into from
Jul 29, 2024
Merged

feat(sink): merge small chunks for sink executor #17825

merged 1 commit into from
Jul 29, 2024

Conversation

chenzl25
Copy link
Contributor

@chenzl25 chenzl25 commented Jul 26, 2024 •
edited
Loading

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@chenzl25 chenzl25 requested review from st1page, wenym1 and StrikeW July 26, 2024 09:29
@chenzl25 chenzl25 requested a review from fuyufjh July 29, 2024 07:53
st1page
st1page approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@st1page st1page left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
will we optimize the case that it does not buffer chunks within a epoch? such as batching with timeout and row numbers?

@chenzl25
Copy link
Contributor Author

LGTM. will we optimize the case that it does not buffer chunks within a epoch? such as batching with timeout and row numbers?

Yes, let's see whether current PR works first.

@chenzl25 chenzl25 added need-cherry-pick-release-1.9 need-cherry-pick-release-1.10 Open a cherry-pick PR to branch release-1.10 after the current PR is merged labels Jul 29, 2024
@chenzl25 chenzl25 enabled auto-merge July 29, 2024 10:22
@chenzl25 chenzl25 added this pull request to the merge queue Jul 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 29, 2024
@chenzl25 chenzl25 added this pull request to the merge queue Jul 29, 2024
Merged via the queue into main with commit 657f85e Jul 29, 2024
43 of 44 checks passed
@chenzl25 chenzl25 deleted the dylan/merge_small_chunk_for_sink_executor branch July 29, 2024 14:19
github-actions bot pushed a commit that referenced this pull request Jul 29, 2024
@chenzl25
feat(sink): merge small chunks for sink executor (#17825)
f8adc74
@github-actions github-actions bot mentioned this pull request Jul 29, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Jul 29, 2024
@chenzl25
feat(sink): merge small chunks for sink executor (#17825)
8b591f8
@github-actions github-actions bot mentioned this pull request Jul 29, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jul 30, 2024
@github-actions @chenzl25
feat(sink): merge small chunks for sink executor (#17825) (#17846)
8d9036d 
Co-authored-by: Dylan <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Jul 30, 2024
@github-actions @chenzl25
feat(sink): merge small chunks for sink executor (#17825) (#17847)
eb12ef0 
Co-authored-by: Dylan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st1page st1page st1page approved these changes

@StrikeW StrikeW StrikeW approved these changes

@wenym1 wenym1 Awaiting requested review from wenym1

@fuyufjh fuyufjh Awaiting requested review from fuyufjh

Assignees
No one assigned
Labels
need-cherry-pick-release-1.10 Open a cherry-pick PR to branch release-1.10 after the current PR is merged type/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: merge small chunks for sink executor
3 participants
@chenzl25 @StrikeW @st1page